Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: Fix beauty template image #2889

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

pbakaus
Copy link
Contributor

@pbakaus pbakaus commented Jul 1, 2020

This fixes a remaining beauty template image and replaces it with a royalty free image and copy.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #2889 into master will decrease coverage by 13.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2889       +/-   ##
===========================================
- Coverage   81.30%   67.94%   -13.36%     
===========================================
  Files         701      693        -8     
  Lines       11900    11804       -96     
===========================================
- Hits         9675     8020     -1655     
- Misses       2225     3784     +1559     
Flag Coverage Δ
#karmatests ?
#unittests 66.50% <ø> (ø)
Impacted Files Coverage Δ
assets/src/dashboard/app/index.js 0.00% <0.00%> (-100.00%) ⬇️
assets/src/edit-story/elements/image/icon.js 0.00% <0.00%> (-100.00%) ⬇️
assets/src/edit-story/elements/shape/icon.js 0.00% <0.00%> (-100.00%) ⬇️
assets/src/edit-story/elements/video/icon.js 0.00% <0.00%> (-100.00%) ⬇️
assets/src/edit-story/components/canvas/canvas.js 0.00% <0.00%> (-100.00%) ⬇️
...ssets/src/edit-story/components/canvas/navLayer.js 0.00% <0.00%> (-100.00%) ⬇️
...ssets/src/edit-story/components/workspace/index.js 0.00% <0.00%> (-100.00%) ⬇️
...ssets/src/edit-story/elements/image/textContent.js 0.00% <0.00%> (-100.00%) ⬇️
...ets/src/edit-story/elements/video/onDropHandler.js 0.00% <0.00%> (-100.00%) ⬇️
...ts/src/edit-story/components/panels/layer/panel.js 0.00% <0.00%> (-100.00%) ⬇️
... and 153 more

@swissspidy swissspidy added Group: Templates Type: Bug Something isn't working labels Jul 1, 2020
@swissspidy swissspidy changed the title Fix beauty template image Templates: Fix beauty template image Jul 1, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2020

Size Change: -9 B (0%)

Total Size: 1 MB

Filename Size Change
assets/js/stories-dashboard.js 527 kB -9 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 269 B 0 B
assets/css/stories-dashboard.css 305 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/edit-story.js 457 kB 0 B
assets/js/web-stories-embed-block.js 15.7 kB 0 B

compressed-size-action

Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Works as expected:

Screenshot 2020-07-01 at 08 35 56

@swissspidy
Copy link
Collaborator

Failing karma tests can be neglected because of #2887

@swissspidy swissspidy merged commit f1544f0 into master Jul 1, 2020
@swissspidy swissspidy deleted the fix-beauty-template branch July 1, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Templates Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants