Added drag and drop in the home screen #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, let me review it. |
monkeyWie
requested changes
May 27, 2024
| 'other': details.files[0].name | ||
| }; | ||
| Get.rootDelegate.offNamed(Routes.CREATE, | ||
| arguments: !Util.isWeb() ? args['web'] : args['other']); |
|
Web compatibility would be a pain, so we can just support desktops. |
|
Done modifying only for desktop. Please check |
monkeyWie
requested changes
May 30, 2024
Comment on lines
+56
to
+57
| final args = { | ||
| 'other': details.files[0].name |
There was a problem hiding this comment.
There should be details.files[0].path
There was a problem hiding this comment.
And there can return early when it is on web:
if (Util.isWeb()) {
return;
}
monkeyWie
approved these changes
Jun 26, 2024
yiyebaofu0518
requested review from
yiyebaofu0518
and removed request for
yiyebaofu0518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
Files can now be dropped on the home screen to download them. Without using global
urlController.