-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout breaks if report does not fit in the available width #2023
Comments
It's a bug alright. There is support for hyphenation, but somewhere along the line, it broke. Hyphenation is supposed to only kick in when this situation happens. Thanks for reporting. The padding is actually necessary for color support, so I'd rather fix hyphenation. |
So if this is a bug, when is the "… does not fit in the available width" warning then actually necessary? |
looks like proper hyphenation support has been in backlog for a while: #74 |
This addresses GothenburgBitFactory#2023 For many years linewrap has been broken in taskwarrior, rendering the application basically useless in terminals with short widths and tasks containing URLs in them... This janky line wrap patch sort of works but introduces other minor graphical glitches. But seeing as no one took the time to fix it over the years, here some a small salvation to those who suffer as much as me. One problem of this patch is, when a line is wrapped, it may be 1 column smaller than the terminal width, resulting in each line not fully utilizing the terminal width. This patch is not polished and could probably need to be tended by someone who cares more.
This addresses #2023 For many years linewrap has been broken in taskwarrior, rendering the application basically useless in terminals with short widths and tasks containing URLs in them... This janky line wrap patch sort of works but introduces other minor graphical glitches. But seeing as no one took the time to fix it over the years, here some a small salvation to those who suffer as much as me. One problem of this patch is, when a line is wrapped, it may be 1 column smaller than the terminal width, resulting in each line not fully utilizing the terminal width. This patch is not polished and could probably need to be tended by someone who cares more.
This is now fixed on our latest releases. Tested on 2.5.2, 2.5.3, 2.6.0.
|
Dear @tbabej First a huge thanks to you and all the other developpers for developping and maintaining taskwarrior which is awesome. I just installed taskwarrior yesterday (I have version 2.5.3 on MacOS) but I still got the error message: |
i noticed that the bug seems to be fixed, if the long text in question is applied as an Annotation. If the task main description itself, has a very long name (say a URL), then the report display seems broken. tldr: this fix works on annotations, not the main task description itself. |
@mhalano what version are you on? |
I'm using 2.5.3. |
I see. I think what is happening here is that the description stretches the width (the other half of this bug), so the annotation does not get wrapped, because it doesn't have to. I'll reopen this and try to see if we can fix this in 2.6.0. |
This is now fixed on 2.6.0:
|
I'm getting the warning
The report has a minimum width of 225 and does not fit in the available width of 211.
when runningtask all
because of a really long line:The native wrapping of the the terminal then unfortunately breaks the whole layout, as every line which was just one line height before is now two lines high:
The problem is that every line is padded to same length as the longest line.
I guess the correct fix for this would be to support native wrapping in taskwarrior, so that the description line gets wrapped properly. However, I don't know how time-consuming this will be.
Maybe as a quick-fix there could be a config flag to not pad lines with spaces?
This will make the highlighted lines look jagged, but still better than this awful wrapping.
What do you think?
The text was updated successfully, but these errors were encountered: