Fix urgency inheritance for negative-urgency tasks #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2732. Currently, if a task with negative urgency inherits its urgency from another task with negative urgency, the resulting calculated urgency can be erroneously positive. See the example given in #2732 for more details.
The root of the issue is that when calculating inherited urgency, the algorithm chooses the maximum of
FLT_MINand the urgency of its blocked tasks.FLT_MINis is the minimum positive float value, so-FLT_MAXshould be used instead. Thanks to @smemsh for diagnosing the issue in the comments of the initial bug report.