Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement due dates related methods for Task and TaskMut #3145

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Implement due dates related methods for Task and TaskMut #3145

merged 3 commits into from
Jul 25, 2023

Conversation

Treenhan
Copy link
Contributor

Description

Implement due dates related methods for Task and TaskMut

Additional information

All tests pass

Fixes #2879

@Treenhan Treenhan mentioned this pull request Jul 21, 2023
Closed
@djmitche djmitche self-requested a review July 24, 2023 21:38
djmitche
djmitche reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- looking good! Once this is done, the next PR will be to reflect it in taskchampion/lib

taskchampion/taskchampion/src/task/task.rs Outdated Show resolved Hide resolved
taskchampion/taskchampion/src/task/task.rs Show resolved Hide resolved
djmitche
djmitche approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll get this merged, and the next bit is to add functionality in taskchampion/lib to match this.

@djmitche djmitche merged commit 76b21f4 into GothenburgBitFactory:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[taskchampion] Implement due dates
2 participants
@Treenhan @djmitche