Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for task expiration #3546

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

djmitche
Copy link
Collaborator

@djmitche djmitche commented Jul 7, 2024

This adds optional support for task expiration, implemented by calling the relevant Replica method.

This is currently fixed at 180 days, but we can add configuration later.

I chose to do this on sync for two reasons:

  • Any modifications to tasks from other replicas are likely to have just been received, updating the modified timestamp and saving a task from being updated-and-deleted. Such a task will end up in a zombie state with only the updated properties surviving.
  • This is a fairly expensive operation (scan of the full DB) so not something we should do interactively, like renumbering the working set.

Fixes #3402.

@djmitche djmitche requested a review from felixschurk July 7, 2024 19:02
Copy link
Collaborator

@felixschurk felixschurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over it and as far as I can understand everything works as expected and is documented.

@djmitche
Copy link
Collaborator Author

djmitche commented Jul 9, 2024

I looked over it and as far as I can understand everything works as expected and is documented.

I can't ask for anything more than that in a review!

@djmitche djmitche merged commit 213b9d3 into GothenburgBitFactory:develop Jul 9, 2024
14 checks passed
@felixschurk
Copy link
Collaborator

Interesting that here the tests all run fine, however when merged into develop (213b9d3) the tests fail in some of the runners.

I don't understand why and how.

@djmitche
Copy link
Collaborator Author

djmitche commented Jul 11, 2024

Huh, I re-ran them and they passed. If they continue to fail we can try reverting this, but it really seems unrelated.

@felixschurk
Copy link
Collaborator

Yes, I don't think it has to do with the changes.
But still strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional support for automatically expiring old tasks
2 participants