-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colors to summary #463
Conversation
Signed-off-by: Lim Ding Wen <limdingwen@gmail.com>
Hang on, realised this doesn't correctly handle cases where the tag has no color. Documenting down differences in color handling logic:
Because of this, I'll need to adapt the logic from Edit: Implementation screenshot |
I'm unable to test if the code works with Edit: On second look, it seems like |
Signed-off-by: Lim Ding Wen <limdingwen@gmail.com>
The PR is ready to be reviewed! 😄 Not sure what's with the GH tests, it worked on the previous commit :P This commit literally only added 2 whitespaces to fix the formatting |
Signed-off-by: Lim Ding Wen <limdingwen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
The error in the previous run were due to another issue (already fixed) connected with the execution time. See 👉🏻 #466 |
Uses the existing
intervalColor
function. Includes documentation consistent with CmdTags and CmdChart.Closes #459.