Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce browserify & turn Terminal into EventEmitter #15

Closed
jedi4ever opened this issue Apr 23, 2013 · 1 comment
Closed

introduce browserify & turn Terminal into EventEmitter #15

jedi4ever opened this issue Apr 23, 2013 · 1 comment
Milestone
1.0

Comments

@jedi4ever
Copy link
Contributor

This commit removes the BrowserBuild and introduces Browserify as discussed.
Terminal now inherits from EventEmitter and can emit events.
A simple inject event is emitted and an in browser test for testing event emitted is added.

jedi4ever@02a347d

Please merge #14 first then I can submit a pull request for this.
@jedi4ever
Copy link
Contributor Author

any comments on this? I think it still fits the future model well as it introduces the new emitting pattern.

Gottox added a commit that referenced this issue May 6, 2013
@Gottox
merge from jedi4ever, basic support for Events described in #15 and #16
951b441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@jedi4ever