Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side menu not showing current page correctly when there is sub item #1569

Closed
twjeffery opened this issue Jan 19, 2024 · 6 comments · Fixed by #1843
Closed

Side menu not showing current page correctly when there is sub item #1569

twjeffery opened this issue Jan 19, 2024 · 6 comments · Fixed by #1843
Assignees
@vanessatran-ddi
Labels
Bug Something isn't working Design system website released on @alpha Released into alpha. released Released into production.

Comments

@twjeffery
Copy link
Collaborator

Bug outlined in video below:

Screen.Recording.2024-01-18.at.6.33.55.PM.mov

Acceptance Criteria:

  • Side menu should show only current page as active
@twjeffery twjeffery added Bug Something isn't working Design system website labels Jan 19, 2024
@ArakTaiRoth ArakTaiRoth mentioned this issue Feb 5, 2024
Closed
@vanessatran-ddi vanessatran-ddi self-assigned this May 22, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 27, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
de4e4f5 
…there is sub item
@vanessatran-ddi vanessatran-ddi mentioned this issue May 27, 2024
Merged
7 tasks
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 27, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
e84ce2d 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 27, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
4561535 
…there is sub item
@vanessatran-ddi vanessatran-ddi linked a pull request May 27, 2024 that will close this issue
fix(#1368,#1792,#1772,#1569): fixing link active when router change #1843
Merged
7 tasks
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 27, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
885dce2 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 27, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
6300043 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 28, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
cb05d9c 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 28, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
8f68534 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 28, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
e1036a0 
…there is sub item
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 29, 2024
@vanessatran-ddi
fix(GovAlta#1569): side menu not showing current page correctly when …
a4d99d3 
…there is sub item
ArakTaiRoth pushed a commit that referenced this issue May 29, 2024
@vanessatran-ddi @ArakTaiRoth
fix(#1569): side menu not showing current page correctly when there i…
de245a7 
…s sub item
@tzuge
Copy link
Collaborator

tzuge commented May 29, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.56 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label May 29, 2024
@tzuge
Copy link
Collaborator

tzuge commented May 30, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jun 11, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 4.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanessatran-ddi vanessatran-ddi

Labels
Bug Something isn't working Design system website released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1368,#1792,#1772,#1569): fixing link active when router change vanessatran-ddi/ui-components
3 participants
@tzuge @twjeffery @vanessatran-ddi