Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Header: Console error at specific width #1900

Closed
ArakTaiRoth opened this issue Jun 7, 2024 · 6 comments · Fixed by #1998
Closed

App Header: Console error at specific width #1900

ArakTaiRoth opened this issue Jun 7, 2024 · 6 comments · Fixed by #1998
Assignees
@syedszeeshan
Labels
Bug Something isn't working ready-for-contribution Use to mark any story that is contributor friendly released on @alpha Released into alpha. released Released into production.

Comments

@ArakTaiRoth
Copy link
Collaborator

Info

If you reduce the resolution of the window to 1024px or below, a console error comes up, but only when the App Header component is on the screen (so basically every page for most of our services).

There are no functional issues with the App Header that have been spotted, just the console error:

image

Acceptance Criteria:

  1. Console error is removed from App Header at 1024px or lower resolution
@ArakTaiRoth ArakTaiRoth added the Bug Something isn't working label Jun 7, 2024
@ArakTaiRoth
Copy link
Collaborator Author

Might be related to #1952 , as it looks like the same error

@ArakTaiRoth ArakTaiRoth added the ready-for-contribution Use to mark any story that is contributor friendly label Jun 24, 2024
@syedszeeshan syedszeeshan self-assigned this Jul 11, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Jul 12, 2024
@syedszeeshan
fix(GovAlta#1900): fix appheader console error at 1024px or lower
de3e085
@ArakTaiRoth ArakTaiRoth linked a pull request Jul 17, 2024 that will close this issue
fix(#1900): fix app header console error below 1024px #1998
Merged
3 tasks
ArakTaiRoth pushed a commit that referenced this issue Jul 17, 2024
@syedszeeshan @ArakTaiRoth
fix(#1900): fix appheader console error at 1024px or lower
f4e4672
@tzuge
Copy link
Collaborator

tzuge commented Jul 17, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.83 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Jul 17, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jul 17, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jul 18, 2024

🎉 This issue has been resolved in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jul 18, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jul 18, 2024

🎉 This issue has been resolved in version 4.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Sep 20, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syedszeeshan syedszeeshan

Labels
Bug Something isn't working ready-for-contribution Use to mark any story that is contributor friendly released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1900): fix app header console error below 1024px syedszeeshan/ui-components
3 participants
@ArakTaiRoth @tzuge @syedszeeshan