Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Add application icons #2

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Add application icons #2

merged 6 commits into from
Jul 20, 2022

Conversation

allaeddine-boulefaat
Copy link
Contributor

No description provided.

@allaeddine-boulefaat
Copy link
Contributor Author

Preview

@daudix
Copy link
Member

daudix commented Jul 19, 2022

Hello, I have some advices to make it look better:

  • Use a little brighter colors on a paint roller
  • Remove depth from paint roller hand
  • Remove shadows, as it not allowed by GNOME HIG
  • Make shape follow GNOME HIG

Somthing like this:

image

@ArtyIF
Copy link
Contributor

ArtyIF commented Jul 19, 2022

In my opinion the depth effect should be removed almost entirely (outside of the window), since Libadwaita is flat and all. Obviously make it so that the metal part was visible.

@daudix
Copy link
Member

daudix commented Jul 19, 2022

Also, Congratulations with First icon and First PR!

@ArtyIF ArtyIF mentioned this pull request Jul 19, 2022
@allaeddine-boulefaat
Copy link
Contributor Author

Preview

@daudix
Copy link
Member

daudix commented Jul 19, 2022

Roller looks a bit dark, maybe use gradient directly instead of black tint?

And make metal handler a bit thicker (3-4px)

@allaeddine-boulefaat
Copy link
Contributor Author

allaeddine-boulefaat commented Jul 19, 2022

Preview

@ArtyIF
Copy link
Contributor

ArtyIF commented Jul 20, 2022

How about something like this?

Regular version:
Regular version

Nightly/dev version:
Dev version

@allaeddine-boulefaat
Copy link
Contributor Author

allaeddine-boulefaat commented Jul 20, 2022

How about something like this?

the regular version is too flat for a gnome icon , the devel version doesn't follow gnome's HIG and making the header bar that transparent made it almost invisible
i guess the change to the color combination on the roller is good , i will add that to the pr

@allaeddine-boulefaat
Copy link
Contributor Author

Preview

@ArtyIF
Copy link
Contributor

ArtyIF commented Jul 20, 2022

the devel version doesn't follow gnome's HIG

How exactly? I didn't find anything in the GNOME HIG about nightly versions outside of App Icon Preview being able to generate the nightly versions itself.

@allaeddine-boulefaat
Copy link
Contributor Author

How exactly? I didn't find anything in the GNOME HIG about nightly versions outside of App Icon Preview being able to generate the nightly versions itself.

it's not mentioned anywhere but since all gnome nightly icons use the same stripes in the same place that's the convention

@allaeddine-boulefaat
Copy link
Contributor Author

Preview

@ArtyIF
Copy link
Contributor

ArtyIF commented Jul 20, 2022

How exactly? I didn't find anything in the GNOME HIG about nightly versions outside of App Icon Preview being able to generate the nightly versions itself.

it's not mentioned anywhere but since all gnome nightly icons use the same stripes in the same place that's the convention

How would a nightly icon look like in this case? Actually, does this program even need it?

@ArtyIF ArtyIF added enhancement New feature or request status/more-info-needed Further information is requested labels Jul 20, 2022
@allaeddine-boulefaat
Copy link
Contributor Author

How would a nightly icon look like in this case? Actually, does this program even need it?
com github marhkb adwaita-manager Devel

i don't think this app needs it since it's not being published on gnome nightly flatpak repo

@ArtyIF
Copy link
Contributor

ArtyIF commented Jul 20, 2022

Okay, I think it's ready to merge. How would you like to be credited? Is Allaeddine Boulefaat https://github.com/allaeddineomc good?

@ArtyIF ArtyIF merged commit f2fc15c into GradienceTeam:main Jul 20, 2022
@ArtyIF ArtyIF removed the status/more-info-needed Further information is requested label Jul 20, 2022
@allaeddine-boulefaat
Copy link
Contributor Author

Okay, I think it's ready to merge. How would you like to be credited? Is Allaeddine Boulefaat https://github.com/allaeddineomc good?

make it "Allaeddine https://github.com/allaeddine-boulefaat"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants