Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

feat: initial community presets download mechanism #255

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

tfuxu
Copy link
Member

@tfuxu tfuxu commented Aug 24, 2022

This PR adds an initial mechanism for downloading community presets using info from presets.json file.

In the future, there should be added some sort of fail-save procedure to prevent Gradience from crashing if perhaps Github was offline (maybe a exception handler as a dialog?).

@tfuxu tfuxu marked this pull request as ready for review August 24, 2022 19:59
@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

Could you send a screenshot of the result ?

@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

image_20220824221912

I've started doing this.

@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

Thanks again for your PR 🚀😎🥳

@tfuxu
Copy link
Member Author

tfuxu commented Aug 24, 2022

Screenshot from 2022-08-24 22-54-27

Also, here's in action:
Screencast from 08-24-2022 11:58:31 PM.webm

@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

Amazing 🙂🚀. It's exactly what I wanted to do 😅😎. Thanks.

@0xMRTT 0xMRTT merged commit c21cc40 into GradienceTeam:next Aug 24, 2022
@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

For the offline case, we can just add a new page to the stack which say that the computer is offlinr

@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

Also, don't forget to add yourself in about dialog 👍

@tfuxu
Copy link
Member Author

tfuxu commented Aug 24, 2022

Amazing slightly_smiling_facerocket. It's exactly what I wanted to do sweat_smilesunglasses.

Yea, I was faster 😅️

Thanks.

No problem, if I'm using something, I'll always try to improve it

@tfuxu
Copy link
Member Author

tfuxu commented Aug 24, 2022

For the offline case, we can just add a new page to the stack which say that the computer is offlinr

Yes, it can be just a status page

@0xMRTT
Copy link
Member

0xMRTT commented Aug 24, 2022

Also, if you have matrix, I suggest you to join the matrix room

@tfuxu
Copy link
Member Author

tfuxu commented Aug 25, 2022

Also, if you have matrix, I suggest you to join the matrix room

ok, why not :^)

@tfuxu tfuxu deleted the next branch September 10, 2022 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants