Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Emulates blossom deployment with docker-compose #130

Merged
merged 5 commits into from
Jun 8, 2021
Merged

Conversation

TheLonelyGhost
Copy link
Member

@TheLonelyGhost TheLonelyGhost commented Jun 6, 2021

Description:

For closer emulation to what is running on prod, here's a docker-compose manifest and associated files for running blossom entirely locally using Docker and docker-compose as an orchestrator.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

Anything in `docker/` is going to be mounted in a different spot, so
things like "I'm unable to find this import you're referencing" mean
nothing.
The docker approach helps with manual testing, but is not (currently)
built for running automated tests. That would need more effort put into
it, if it's even feasible.
@TheLonelyGhost TheLonelyGhost marked this pull request as ready for review June 6, 2021 04:55
@TheLonelyGhost TheLonelyGhost requested a review from a team as a code owner June 6, 2021 04:55
environment:
POSTGRES_DB: 'mydb'
POSTGRES_PASSWORD: 'hunter2'
POSTGRES_USER: 'roto_rooter'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we go for a bit more Blossom-like credentials?

Copy link
Member Author

@TheLonelyGhost TheLonelyGhost Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but that was to test that we're actually pulling in values from environment variables and showing you could make the creds anything. And that's important from a security standpoint if we need to quickly pivot.

Here's an example: If username/password get owned, rotating just the password is going to leave it open to brute force attack. They know the first factor (username) and they can repeatedly guess at the second (password). Eventually they'll guess right. Will we notice before that happens and lock down access? Hopefully. I'd rather not make that wager in the first place.

I suppose we could have them be different than the defaults in the code, but still blossom-inspired. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, my remark was indeed about the default values in code :)

Copy link
Member

@itsthejoker itsthejoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheLonelyGhost TheLonelyGhost merged commit 9ebdd8d into master Jun 8, 2021
@TheLonelyGhost TheLonelyGhost deleted the local-docker branch June 8, 2021 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants