This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
add slack verification #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: this does appear to actually work |
TimJentzsch
approved these changes
Dec 14, 2021
|
The replay prevention is straight from Slack's documentation, so it's something we can add a test for but beyond that I'm taking their word. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: N/a
Description:
Need to actually verify that requests coming in on the slack endpoint actually come from slack. This is a security hole and also since I'm about to implement a command that modifies data, we need to be extra sure. The actual process for verifying is a pain in the butt, but I think that this is accurate.
Checklist: