This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Add utc_offset query parameters to submission/rate and submission/heatmap endpoints
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the client to specify the UTC offset in seconds.
itsthejoker
approved these changes
Jan 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: Closes #301
Description:
This allows the client to specify the UTC offset in seconds, which can be used to localize the results.
I tried to do this client-side on Buttercup, but for the
ratewe don't have enough info to do it and forheatmapit doesn't work for time zones like+01:30.So moving this functionality to the server side makes sense for us (and might be beneficial for third-party clients or our other bots).
Checklist: