Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Enable more linting rules #481

Merged
merged 5 commits into from
May 10, 2023
Merged

Enable more linting rules #481

merged 5 commits into from
May 10, 2023

Conversation

TimJentzsch
Copy link
Contributor

Relevant issue: N/A

Description:

  • Increase the line length from 88 to 100 (for both black and ruff). We have more than enough screen space to display 100 chars and it often makes the code look nicer and have less lines.
  • Enable more doc lints that were disabled before. They are either formatting related and automatically fixable or just had one violation that I could easily fix. For example, the first doc line now starts consistently directly after the opening quotation marks, which is the convention recommended by Python.
  • Enable the DTZ type of lints which enforce that we set a timezone for everything. This is important for the database and has caused errors before where we missed it. I disabled it for tests for now because there are a ton of violations.

@TimJentzsch TimJentzsch requested a review from a team as a code owner May 10, 2023 12:50
@TimJentzsch TimJentzsch merged commit 5d712f8 into master May 10, 2023
@TimJentzsch TimJentzsch deleted the better-ruff-linting branch May 10, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants