Echoing messages back to the client change how embedded channels in them work. #13
Conversation
|
The issue is on jschan like you said in GraftJS/jschan#28, which is good and bad at the same time. I'll comment the tests here, and then move to the jsChan issue. |
| @@ -141,7 +140,7 @@ module.exports = function allTransportTests(buildServer, buildClient) { | |||
| client.write({ hello: 'world' }); | |||
| }); | |||
|
|
|||
| it('should support sending a Readable to the other side', function(done) { | |||
| it.skip('should support sending a Readable to the other side', function(done) { | |||
There was a problem hiding this comment.
why are you skipping this?
|
However, I think that want you want to achieve and the actual bug in jschan is hightlighted by https://github.com/GraftJS/graft/blob/test/echo-refactor-2/test/all_transports.js#L192-L229, which is the same of 'test/echo-refactor', but by echoing the original message. This does not work because jschan does not support echoing a Channel, i.e. you cannot create an infinite message loop. Is it sound? |
|
i ended up fixing it this way : GraftJS/aetherboard@089836d |
I ran into this when I was working on something in Aetherboard,
so I put it together in a simplified test case to help debug/fix the issue.
The first new test, ensures that i can embed a writeable into a message,
and then while piping the channel it is sent on,
I should always be able to pipe the writeable into something.
This is with any of the sessions, or even with just 1 graft instance.
The second test, is where I pass a return channel to the server and expect
it to echo the messages back to me.
I expect to be able to pipe the return channel messages in the same way as the
messages are piped on the remote side, or as they are piped directly from the client.
What happens is that the channel attached to the messages that gets echoed back,
can no longer be piped from.
Echoing messages back is actually one of the more common network behaviours,
such as for instance in group chat. When I post a message, I need to wait for it to be
sent back to me to be added into the single stream of conversation.
any hints where to start looking to fix this @mcollina ?