Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis Parsing Fix #240

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Genesis Parsing Fix #240

merged 12 commits into from
Oct 12, 2023

Conversation

jenr24G
Copy link
Contributor

@jenr24G jenr24G commented Oct 11, 2023 •
edited by trevorbernard
Loading

The Mina Indexer parses account balances from the genesis ledger incorrectly. Mina genesis ledgers are denominated in regular mina, while the Mina Indexer expects NanoMina.

Solves #239

This PR Makes the following changes:

  • Parse the account balance on genesis ledger json files using the Decimal type
  • Panic if the account balance doesn't exist or can't be converted to NanoMina (indicating a faulty genesis ledger)

trevorbernard
trevorbernard suggested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@trevorbernard trevorbernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit or regression test that proves it's been fixed

jenreiss24 and others added 2 commits October 11, 2023 14:59
@jenreiss24
fix tests and add test for genesis ledger parsign
3c1eef9
@jenr24G
Merge branch 'main' into genesis-parsing-fix
bbe368e 
Signed-off-by: Jen Cecelia Reiss <108204491+jenr24G@users.noreply.github.com>
trevorbernard
trevorbernard suggested changes Oct 11, 2023
View reviewed changes
test Outdated Show resolved Hide resolved
test Outdated Show resolved Hide resolved
trevorbernard
trevorbernard suggested changes Oct 12, 2023
View reviewed changes
test Outdated Show resolved Hide resolved
@trevorbernard trevorbernard merged commit d79afc8 into Granola-Team:main Oct 12, 2023
5 checks passed
@jenr24G jenr24G deleted the genesis-parsing-fix branch October 12, 2023 16:22
@trevorbernard trevorbernard mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorbernard trevorbernard trevorbernard approved these changes

@robinbb robinbb Awaiting requested review from robinbb robinbb is a code owner

@Isaac-DeFrain Isaac-DeFrain Awaiting requested review from Isaac-DeFrain Isaac-DeFrain is a code owner

Assignees

@jenr24G jenr24G

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenr24G @trevorbernard @jenreiss24