Replace glob with fdir #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrantBirki
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
This is incredible! Thank you so much for contributing and helping to make this project better ❤️
I see that CI is failing but I have a few fixes I'll apply. For now, I will merge and get your changes into this project and then open a new PR to fix things up before I publish a release. Thank you! 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this in passing and thought it'd be cool to have this action use fdir. You can check the benchmarks here. The replacement is relatively simple and doesn't require too many changes.
In my own testing against
glob, fdir is many, many times faster. 9 ops/sec vs 40 ops/sec.