Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Run on Aarch64 #506

Closed
Jongy opened this issue Sep 27, 2022 · 1 comment
Closed

tests: Run on Aarch64 #506

Jongy opened this issue Sep 27, 2022 · 1 comment
Assignees
Labels
aarch64 defined-and-prioritized Tickets that have fully defined the desired outcome & are prioritized to be developed. tests

Comments

@Jongy
Copy link
Contributor

Jongy commented Sep 27, 2022

Our current test suite won't run on Aarch64 for some reason. One of them is that we pin image hashes, and some of those images are available only on x86_64.

As a first step - let's manage to run the full suite once - propose a PR that, after being applied, will allow running the full test suite Lint, build gProfiler container and run tests / test (3.8) (pull_request) on an Aarch64 machine.

After that we can think if we want it enabled in the CI somehow.

@Jongy Jongy added the defined-and-prioritized Tickets that have fully defined the desired outcome & are prioritized to be developed. label Jan 31, 2023
@pfilipko1 pfilipko1 mentioned this issue Feb 13, 2023
3 tasks
Jongy added a commit that referenced this issue Mar 28, 2023
This begins the work towards #506. After this PR, Java profiling tests all pass
on both x86_64 and Aarch64.

Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
Jongy added a commit that referenced this issue Mar 29, 2023
More work towards #506. After this PR, Python profiling tests all pass
on both x86_64 and Aarch64.

Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
Jongy pushed a commit that referenced this issue Apr 11, 2023
@Jongy
Copy link
Contributor Author

Jongy commented Apr 11, 2023

As of 1187648, all container tests pass on Aarch64. I am closing this ticket and opening separate ones for the executable tests & CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 defined-and-prioritized Tickets that have fully defined the desired outcome & are prioritized to be developed. tests
Projects
None yet
Development

No branches or pull requests

2 participants