Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InputColor to append at the body instead of the editor #5750

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

bernesto
Copy link
Contributor

The addresses an issue where we are trying to place a popover palette absolutely positioned over a InputColor element at an arbitrary location on the page. And we need to do this even when the origin element is outside of the editor container node.

To meet this requirement, the popover palette can not be contained anywhere within an offsetParent, and further it must be at the highest z-index. Otherwise it will be subject to the visible area of it's offsetParent and ordered by the parent's z-index. So we are adding that container directly to the body.

@artf artf merged commit 000207e into GrapesJS:dev Mar 14, 2024
2 checks passed
@artf
Copy link
Member

artf commented Mar 14, 2024

Thank you @bernesto Nice job, I really appreciate your prompt response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants