Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support to send options for juice library #31

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

arthuralmeidap
Copy link
Contributor

@arthuralmeidap arthuralmeidap commented Feb 8, 2018

@artf ,

This PR is to add the ability to send some options to the juice library used to inline the css into the html for the get-inlined-html command and when the user clicks on the View Code button.

For the command, I added as optional parameters and when the command runs, for now, it's receiving the same parameters from Juice's API.
For the View Code button, I added a new option for the plugin called juiceOpts. a

You probably know, but those are the options: https://github.com/Automattic/juice#options

What do you think? Any change to get accepted? Suggestions?

@arthuralmeidap
Copy link
Contributor Author

Hi @artf , any news about it?

@arthuralmeidap
Copy link
Contributor Author

@artf , Sorry so much to keep bothering you.. Do you have any feedback on this?

@arthuralmeidap
Copy link
Contributor Author

Hi @artf, any news?

@artf
Copy link
Member

artf commented Jul 18, 2018

Apologize @arthuralmeidap somehow I totally lost this PR ☹️ and don't even remember any of your pings...

BTW thank you for this, really like the idea of passing custom options

@artf artf merged commit 008cd0f into GrapesJS:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants