-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming ConnectionTypes isn't working #106
Comments
@d-exclaimation do you have an idea of how to fix this? |
Not 100% sure what's the issue is caused by. My guess is probably the fact the Message Object Connection is referenced in Chat type and renaming it somehow breaks that. I haven't used it personally in a while but I can take a look at it |
While on this topic, there's probably some sense in rethinking the Connection API sometime. Some nice improvements would be:
These improvements would arguably make the Connection feature that much more powerful. I have a bit of an idea of how this could be done, but my understanding is that there are issues around how to make this work with Codable. |
@d-exclaimation the renaming issue is obviously more pressing (though it's still not the end of the world), but I thought you may have some ideas on everything else too. And there's always the ability to just create your own custom connections, and that solves all these problems |
The main issue is fixed as of #109. |
Since the main issue is fixed, I created a new issue #110 to discuss other improvements to connections that were mentioned above. |
Renaming connection types, doesn't seem to fully work.
I get the following error:
Fatal error: 'try!' expression unexpectedly raised an error: Type "MessageObjectConnection" was referenced but not defined.
When I don't rename the ConnectionType, then the schema builds, but I end up with
MessageObjectConnection
instead ofMessageConnection
.If I don't include the
Chat
type, then the schema builds with the correctMessageConnection
name.The text was updated successfully, but these errors were encountered: