Scalar customizations #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeedleInAJayStack
force-pushed
the
feature/scalar-extensions
branch
from
dd441df
to
a6708b7
Compare
|
Hey @paulofaria, any thoughts or concerns about this change? |
|
Hey @paulofaria, do you have a bit of time for a code review on this? |
paulofaria
approved these changes
Jul 31, 2023
|
Sorry for the extremely long delay! |
|
No worries! Thanks Paulo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to fully customize the
serialize,parseValue, andparseLiteralbehavior of a scalar at declaration time. This allows more complex scalars (such as untyped JSON) to be implemented on top of Graphiti.This repo's needs were a motivation for these changes.
This is a minor version bump