Bug Fix: Issue#4: The gulp process should not exit now #373
Conversation
|
Thanks @krshubham, could you please review the indentation and trailing spaces using our jshint rules in your editor? Using Atom editor is really easy to setup the editor to have automatic indentation. |
|
@atfornes , I have set the indentation to 2 spaces. I hope that's fine as I see the same value written in the .jshintrc file |
There was a problem hiding this comment.
Please, review indentation. We use https://github.com/Grasia/teem/blob/master/.jshintrc config file and jshint tool to ensure this. Please include it in your development settings for future pull requests
gulpfile.js
Outdated
| /*================================================ | ||
| = Report Errors to Console = | ||
| ================================================*/ | ||
|
|
||
| gulp.on('error', function(e) { | ||
| gulp.on('error', function(e) { |
There was a problem hiding this comment.
please, erase trailing white spaces. Using a good linter that uses our jshint rules is the preferred way of doing it.
| } | ||
|
|
||
| return stream.pipe(gulp.dest(path.join(config.dest, 'images'))); | ||
| return stream.pipe(gulp.dest(path.join(config.dest, 'images'))) | ||
| .on('error', endErrorProcess); |
There was a problem hiding this comment.
I believe this .on should be indented two spaces towards the right. Please review that it follows our jshint rules.
| @@ -530,7 +579,9 @@ function buildManifest (env) { | |||
| exclude: 'app.manifest', | |||
| hash: true | |||
| })) | |||
| .pipe(gulp.dest(config.dest)); | |||
| .on('error', endErrorProcess) | |||
| .pipe(gulp.dest(config.dest)) | |||
There was a problem hiding this comment.
please review indentation
There was a problem hiding this comment.
Sorry for this, I'll correct this and keep in mind from next time. Also, I'll for sure configure my text editor or use atom as you said its easy to get it configured. 👍
There was a problem hiding this comment.
don't worry :) just sharing our formatting tools and rules
|
@krshubham, can you please open another pull request for the popover? In addition, please check that:
Thanks! |
|
@atfornes I am closing this right now and will again make a PR as I messed up in this! 😢 |
Issue 4
The basic idea was to use an error handler with each pipe and emit 'end' event to the corresponding pipe.