Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setPrevScene bug #2396

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix setPrevScene bug #2396

merged 1 commit into from
Oct 7, 2023

Conversation

scooterboo
Copy link
Contributor

Description

PR #2366 broke PR #2262
PR #2366 made it the responsibility of the function calling transferPlayerToScene to set the PrevScene since it doesn't always need to be set (chained dungeons)

Issues fixed by this PR

Tested against the quests talked about in #2366 and #2262 . Everything works great.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit d32a75e into Grasscutters:development Oct 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants