Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Tower Data && Set The Tower Schedule #676

Merged
6 commits merged into from
May 8, 2022

Conversation

Akka0
Copy link
Contributor

@Akka0 Akka0 commented May 8, 2022

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

#661

Type of changes

  • Now tower data can be persisted in the database
  • Fix the problem of monster spawn
  • Add command unlocktower to unlock all floors of the tower
  • Now you can set the schedule of the tower floor
  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@tiantian520tt
Copy link
Contributor

Hello! Thank you for your contribution. However, I found that when I pulled this PR to the local deployment, the problem still could not be solved after compilation. 1-3, 2-3, 4-3 still cannot play, and 3-1 still has an error. Please have a look. Thank you.
(translated from Baidu)

@Akka0
Copy link
Contributor Author

Akka0 commented May 8, 2022

Hello! Thank you for your contribution. However, I found that when I pulled this PR to the local deployment, the problem still could not be solved after compilation. 1-3, 2-3, 4-3 still cannot play, and 3-1 still has an error. Please have a look. Thank you. (translated from Baidu)

I have tried, and it actually works.

@tiantian520tt
Copy link
Contributor

yes. When I restart my server system, it suddenly takes effect. thank you.

@tiantian520tt
Copy link
Contributor

fantastic! Everything is running normally. But I want to ask you, dear sir, how to use the unlockpower command? I didn't find the corresponding documentation.

@tiantian520tt
Copy link
Contributor

At present, I only found that the progress of killing monsters does not increase on the 8th floor. Others are normal.

@ghost
Copy link

ghost commented May 8, 2022

Can you fix your merge conflicts? Good work otherwise.

@tiantian520tt
Copy link
Contributor

I think there will be errors in the merging of upper and lower tasks after level 5, right. Unfortunately, I'm not very good at coding.

@Akka0
Copy link
Contributor Author

Akka0 commented May 8, 2022

ur merge conflicts? Good work otherwise.

Done.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - ignore this comment.

@ghost ghost merged commit 916b741 into Grasscutters:development May 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants