Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the following issues: #726

Merged
2 commits merged into from
May 10, 2022
Merged

Fix the following issues: #726

2 commits merged into from
May 10, 2022

Conversation

Secretboy-SMR
Copy link
Contributor

@Secretboy-SMR Secretboy-SMR commented May 9, 2022

  1. HashMap non-thread-safe issus
  2. Fix the same problem in pr621, but use a better implementation

Add the following functions:

  1. There is now a language cache inside getLanguage to prepare for different languages corresponding to different time zones where the accounts in the server are located
    The current implementation is unlikely to have an und situation, so there is no need to deal with it separately

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

1. HashMap non-thread-safe issus
2. Fix the same problem in pr621, but use a better implementation

Add the following functions:
1. There is now a language cache inside getLanguage to prepare for different languages corresponding to different time zones where the accounts in the server are located
@ghost ghost requested a review from KingRainbow44 May 9, 2022 10:06
@ghost ghost merged commit cba16f2 into Grasscutters:development May 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant