Support subscribing to a subscription server #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stream_client has been cleaned up:
- Remove the old (insecure) TLS "support"
- Support for sending an initial message (requried to hook into
subscriptions)
In addition tests hav been added to validate the behaviour of the
subcription server/ client, and some memory issues have been resolved
Pull Request Test Coverage Report for Build 46
💛 - Coveralls |
Additional tests for validating the behaviour when the server falls over, and bug fixes to the client to handle this cleanly
- Allow for plenty of error in ping-driven shutdown (valgrind slows us
right down...)
- Make sure the client is actually shutdown when aborting...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream_client has been cleaned up:
subscriptions)
In addition tests hav been added to validate the behaviour of the
subcription server/ client, and some memory issues have been resolved