Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sort #46

Open
GrayJack opened this issue Sep 27, 2019 · 2 comments
Open

Implement sort #46

GrayJack opened this issue Sep 27, 2019 · 2 comments
Labels
A-tool Area: Binary tool C-tracking-issue Category: A tracking issue for an feature. Hacktoberfest Hacktoberfest

Comments

@GrayJack
Copy link
Owner

No description provided.

@allevo
Copy link
Contributor

allevo commented Oct 10, 2020

Can I try to implement this?

@GrayJack
Copy link
Owner Author

GrayJack commented Oct 11, 2020 •
edited
Loading

Of course!! 😄
Any contributions are welcome

@GrayJack GrayJack added the Hacktoberfest Hacktoberfest label Oct 11, 2020
@allevo allevo mentioned this issue Oct 11, 2020
Merged
bors bot added a commit that referenced this issue Oct 27, 2020
@bors @allevo @GrayJack
Merge #129
ae0e46d 
129: Implement sort r=GrayJack a=allevo

In this PR there's the first implementation of `sort` command ( #46 )

We need to discuss about:
- what happen when a files doesn't exists: `sort` ignores it or fails?
- which flags should we implement? No one is implemented here.
- for the time being, the implementation is in memory and no temp file technique is implemented
- shall we support stdin as input?
- for test purpose, use `println!` macro is not a good choice: what we can use instead?

Co-authored-by: Tommaso Allevi <tomallevi@gmail.com>
Co-authored-by: GrayJack <gr41.j4ck@gmail.com>
@GrayJack GrayJack added C-tracking-issue Category: A tracking issue for an feature. A-tool Area: Binary tool labels Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tool Area: Binary tool C-tracking-issue Category: A tracking issue for an feature. Hacktoberfest Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allevo @GrayJack