Seq: Implement with support for -sw #125
Conversation
yehohanan7
force-pushed
the
dev
branch
3 times, most recently
from
f6a9aec
to
e24ffbc
Compare
seq/Cargo.toml
Outdated
| build = "build.rs" | ||
| edition = "2018" | ||
| description = """ | ||
| Print numbers from FIRST to LAST, in steps of INCREMENT. |
There was a problem hiding this comment.
Can you use the word "display" instead?
seq/src/cli.rs
Outdated
| .version_message("Display version information.") | ||
| .help_short("?") | ||
| .settings(&[ColoredHelp]) | ||
| .arg(Arg::with_name("FIRST INCREMENT LAST").multiple(true)) |
There was a problem hiding this comment.
This arg is required, isn't it?
seq/src/cli.rs
Outdated
| Arg::with_name("SEPERATOR") | ||
| .short("s") | ||
| .long("separator") | ||
| .help("use STRING to separate numbers (default: \\n)") |
There was a problem hiding this comment.
I think the default text would be better with square bracket to be similar to the normal default text that clap uses
seq/src/main.rs
Outdated
| fn max_decimal_digits(args: &[&str]) -> usize { | ||
| args.iter().map(|v| v.len() - v.find(".").map(|pos| pos + 1).unwrap_or(v.len())).max().unwrap() | ||
| } | ||
|
|
||
| fn max_digits(args: &[&str]) -> usize { | ||
| args.iter().map(|v| v.find(".").unwrap_or(v.len())).max().unwrap() | ||
| } |
There was a problem hiding this comment.
Are this unwrap never fail? If they never fail, can you add comments for why it don't fail? If they can fail, it should pass the information forward or be handled on the site
There was a problem hiding this comment.
That's right, it should never fail. I add a comment to make it explicit.
@GrayJack all toml files updated, thanks! |
|
Seems good bors r+ |
|
@GrayJack |
|
Yes, probably is the best thing to do, I was just lazy these days |
Initial implementation, no support for "-f" yet.