No exported method for creating TCPReaders

[zbuc]

There is a newTCPReader function, however it isn't exported. There doesn't seem to be an exported method of creating TCP-based reader applications that use this library.

https://github.com/Graylog2/go-gelf/blob/v2/gelf/tcpreader.go#L22

[joschi]

@zbuc TCPReader is just a helper class for the test cases of go-gelf and is not supposed to be exported.

go-gelf/gelf/tcpwriter_test.go

Line 22 in 4143646

r, _, _, err := newTCPReader("127.0.0.1:0")

[zbuc]

Is there any way of creating a TCP reader instead of UDP? The exported method in Reader.go is only a UDP reader. The readme file for the v2 branch says TCP is supported.

…

On Feb 28, 2018, at 2:59 AM, Jochen Schalanda ***@***.***> wrote: @zbuc TCPReader is just a helper class for the test cases of go-gelf and is not supposed to be exported. https://github.com/Graylog2/go-gelf/blob/4143646226541087117ff2f83334ea48b3201841/gelf/tcpwriter_test.go#L22 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[joschi]

@zbuc go-gelf is a GELF client library and doesn't provide any GELF server parts.

[zbuc]

Oh. In V1 (and V2) some GELF server parts are exposed (and work fine), but only for UDP.

…

On Wed, Feb 28, 2018 at 10:13 AM, Jochen Schalanda ***@***.*** > wrote: @zbuc <https://github.com/zbuc> go-gelf is a GELF *client* library and doesn't provide any GELF server parts. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiyuHhwmdoMuLEvbnfi5Xt8bKNREIJiks5tZWxdgaJpZM4SVpzV> .

[joschi]

Maybe @mariussturm would like to add a comment here.

[mariussturm]

Like @joschi said, this is a pure client library. The reader parts you see are used exclusively for testing and should not be used in any application project.

[zbuc]

FWIW, this code: https://github.com/Graylog2/go-gelf/blob/v2/gelf/reader.go#L24 is publicly exported and works fine for UDP GELF servers from my testing.