Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Index Default initialization server configuration properties #14194

Open
danotorrey opened this issue Dec 12, 2022 · 0 comments
Open

Rename Index Default initialization server configuration properties #14194

danotorrey opened this issue Dec 12, 2022 · 0 comments

Comments

@danotorrey
Copy link
Contributor

danotorrey commented Dec 12, 2022

The capability to initialize index set defaults on new Graylog server installations to specific values was introduced in #13018. As discussed in this comment, we think it would be appropriate to rename/add a prefix to the respective server configuration properties to indicate that they are being used as initialization defaults for the first startup only.

A more general rename of a superset of elasticsearch_ properties is being discussed here. This prefix rename should be coordinated with any general rename, since the config library fallbackPropertyName capability only allows us the ability to specify a single fallback property (Graylog2/JadConfig#113).

Full list of index set default initialization properties:

  • elasticsearch_analyzer
  • elasticsearch_shards
  • elasticsearch_replicas
  • disable_index_optimization
  • index_optimization_max_num_segments
  • index_field_type_periodical_full_refresh_interval
  • rotation_strategy
  • elasticsearch_max_docs_per_index
  • elasticsearch_max_size_per_index
  • elasticsearch_max_time_per_index
  • retention_strategy
  • elasticsearch_max_number_of_indices

One potential prefix discussed with @boosty is index_init_default_. Another option could be index_set_init_default_. Perhaps the elasticsearch_ portion prefix is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants