Restore ClipboardButton to work in non-secure contexts.
#19654
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
reviewed
Jun 17, 2024
| import { CopyButton, Tooltip } from '@mantine/core'; | ||
| import * as React from 'react'; | ||
| import { useCallback, useState } from 'react'; | ||
| import { Tooltip } from '@mantine/core'; |
There was a problem hiding this comment.
Let's use our abstraction from common/Tooltip here.
linuspahl
approved these changes
Jun 17, 2024
dennisoelkers
added a commit
that referenced
this pull request
Jun 18, 2024
* Restore `ClipboardButton` to work in non-secure contexts. * Adding changelog snippet. * Better changelog messages. * Using `Tooltip` abstraction.
9 tasks
linuspahl
pushed a commit
that referenced
this pull request
Jun 18, 2024
…19665) * Restore `ClipboardButton` to work in non-secure contexts. * Adding changelog snippet. * Better changelog messages. * Using `Tooltip` abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This needs a backport to
6.0.Description
Motivation and Context
This PR is restoring
ClipboardButton's functionality to work in non-secure context. In a previous refactoring (#17472), the component was made to useCopyButtonfrom Mantine, which works only in secure contexts (+localhost), unfortunately. This PR is now restoring it by removing the usage of Mantine'sCopyButtonand implements an own component for this, which uses our owncopyToClipboardabstraction, which falls back to a legacy approach in non-secure contexts.Fixes #19643.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: