Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Button component with Mantine. #17472

Merged
merged 29 commits into from
Nov 30, 2023
Merged

Implement Button component with Mantine. #17472

merged 29 commits into from
Nov 30, 2023

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Nov 27, 2023 •
edited
Loading

Description

Motivation and Context

This PR is replacing our react-bootstrap button components with Mantine components, namely:

  • Button: Our generic, go-to button component
  • ClipboardButton: A component wrapping a text which can be copied to the clipboard upon click

/nocl

/jpd Graylog2/graylog-plugin-enterprise#6204

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the refactor/implement-button-with-mantine branch from c3b8b8f to 840cc18 Compare November 28, 2023 11:28
@dennisoelkers dennisoelkers marked this pull request as ready for review November 28, 2023 11:38
@dennisoelkers dennisoelkers force-pushed the refactor/implement-button-with-mantine branch from 74941ca to 626a5b8 Compare November 29, 2023 07:30
linuspahl
linuspahl approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good!

@dennisoelkers
Implementing Button component with Mantine.
f4a544d
@dennisoelkers
Migrating Button/ButtonGroup to mantine.
e789d1b
@dennisoelkers
Migrating ClipboardButton to Mantine.
00e84cf
@dennisoelkers
Showing tooltip when copied.
14631c5
@dennisoelkers
Removing unused prop.
f0274ed
@dennisoelkers
Removing active prop.
ab7d598
@dennisoelkers
Continue supporting href prop.
f4b839f
@dennisoelkers
Passing ARIA label to button component.
eed72b7
@dennisoelkers
Adding testid to Button component props.
75fcb1f
@dennisoelkers
Fixing up finding icon in test.
5510439
@dennisoelkers
Adding default prop.
1a103b0
@dennisoelkers
Using newly defined gray variant.
cb9de58
@dennisoelkers
Adjusting padding/heights for button sizes.
3f34b8e
@dennisoelkers
Adding license header.
c79c1f0
@dennisoelkers
Adding dimensions for large buttons.
c1ab5f1
@dennisoelkers
Allowing submitButtonText to be React element.
94e0fbd
@dennisoelkers
Using disabled styles from theme.
82266c3
@dennisoelkers
Making sure that other part of theme is properly typed.
73f8ec0
@dennisoelkers
Using only other part of theme in functions.
2bd1f65
@dennisoelkers
Migrating ExportExtractor to TS to fix linter hints.
0000108
@dennisoelkers
Suppressing linter hint.
7a78bf8
@dennisoelkers
Adding gap to buttons in ModalSubmit.
4bb8e08
@dennisoelkers
Making ButtonGroup use Mantine ButtonGroup.
107e69d
@dennisoelkers
Renaming indices package index to TS, migrating fallout.
c6f5fcb
@dennisoelkers
Using opacity of 0.65 for disabled buttons.
04e1ac5
@dennisoelkers dennisoelkers force-pushed the refactor/implement-button-with-mantine branch from fca5692 to 8b4f741 Compare November 29, 2023 16:32
@dennisoelkers dennisoelkers merged commit ac960a5 into master Nov 30, 2023
6 of 7 checks passed
@dennisoelkers dennisoelkers deleted the refactor/implement-button-with-mantine branch November 30, 2023 09:41
@dennisoelkers dennisoelkers mentioned this pull request Nov 30, 2023
Merged
9 tasks
This was referenced Jun 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl linuspahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisoelkers @linuspahl