Do not display login form while loading #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2016 13:15
This displays a loading page while we validate the user session, instead of showing the login form. Refs #2770
|
|
||
| render() { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Minor nitpick, do we need this div?
There was a problem hiding this comment.
I don't think so, must be a leftover from some test. Will take a look 👍
|
Tested it in different scenarios, LGTM. I also like the way it improves logging in/full page refreshes a lot. Good work @edmundoa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading Graylog, we currently display the login form while waiting for some resources to load, namely:
Those resources sometimes take a bit to load, and seeing the login form is confusing, as seen in #2770. This PR introduces a loading page that will avoid the confusion of seeing the login form on the screen.
I decided to use the same design used in our login page, as this provides a good transition between the loading and log-in page, which may be show directly before and/or after each other.
Fixes #2770.