Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param selection: add warning message on override-params #475

Closed
jmcook1186 opened this issue Feb 28, 2024 · 0 comments · Fixed by #552
Closed

param selection: add warning message on override-params #475

jmcook1186 opened this issue Feb 28, 2024 · 0 comments · Fixed by #552
Assignees

Comments

@jmcook1186
Copy link
Contributor

Story

As a user I want to get a clear and explicit warning that I'm diverging from the canonical set of parameters when I use the override-params command.

Rationale

We should warn users that they are diverging from our recommended settings by emitting a warning to the terminal when override-params is used. This is because this feature is for advanced users and misuse can break things.

Implementation details

Add warning to when override-params is used

Priority

2/5

Scope

Small change to IF core

Size

<0.5 d

What does "done" look like?

override-params emits warning

Does this require updates to documentation or other materials??

No

What testing is required?

Unit test

Is this a known/expected update?

Mentioned in PR review for params logic

@jmcook1186 jmcook1186 added this to the IF Sprint 7: 19/03/24 - 01/03/24 milestone Feb 28, 2024
@jmcook1186 jmcook1186 modified the milestones: IF Sprint 7: 19/03/24 - 01/03/24, IF Sprint 8: 4/3/24 - 15/3/24 Mar 4, 2024
@jmcook1186 jmcook1186 modified the milestones: IF Sprint 8: 4/3/24 - 15/3/24, IF Sprint 9: 18/3/24 - 29/03/24 Mar 18, 2024
@jmcook1186 jmcook1186 removed the cli label Mar 20, 2024
@narekhovhannisyan narekhovhannisyan linked a pull request Mar 21, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants