Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize unit tests #552

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Parameterize unit tests #552

merged 6 commits into from
Mar 21, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Added unit tests for parameterize lib.

@narekhovhannisyan narekhovhannisyan linked an issue Mar 21, 2024 that may be closed by this pull request
param selection: add warning message on override-params #475
Closed
jmcook1186
jmcook1186 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@narekhovhannisyan narekhovhannisyan merged commit bc2ee54 into main Mar 21, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the parameterize-unit-tests branch March 21, 2024 09:49
@manushak manushak mentioned this pull request Apr 1, 2024
Closed
This was referenced May 17, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees
No one assigned
Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

param selection: add warning message on override-params
3 participants
@narekhovhannisyan @manushak @jmcook1186