Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute tests #565

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Compute tests #565

merged 5 commits into from
Apr 2, 2024

Conversation

narekhovhannisyan
Copy link
Member

@narekhovhannisyan narekhovhannisyan commented Mar 30, 2024 •
edited
Loading

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Implements tests for compute lib.
  • Fixes passing inputs to the plugin by reference issue.

@narekhovhannisyan narekhovhannisyan added this to the IF Sprint 9: 18/3/24 - 29/03/24 milestone Mar 30, 2024
@narekhovhannisyan narekhovhannisyan self-assigned this Mar 30, 2024
@MariamKhalatova
Copy link
Contributor

@narekhovhannisyan you have fixed input reference issue which is not visible in the PR description. Please add.

@narekhovhannisyan narekhovhannisyan linked an issue Apr 1, 2024 that may be closed by this pull request
Plugins have access to manifest inputs #568
Closed
@narekhovhannisyan narekhovhannisyan merged commit 1d6509f into main Apr 2, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the compute-tests branch April 2, 2024 09:05
@manushak manushak mentioned this pull request Apr 9, 2024
Closed
This was referenced May 17, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@manushak manushak manushak approved these changes

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugins have access to manifest inputs
3 participants
@narekhovhannisyan @MariamKhalatova @manushak