Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added success and failure cases to manifests #721

Merged
merged 5 commits into from
May 22, 2024
Merged

Added success and failure cases to manifests #721

merged 5 commits into from
May 22, 2024

Conversation

MariamKhalatova
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@MariamKhalatova MariamKhalatova self-assigned this May 17, 2024
@narekhovhannisyan narekhovhannisyan changed the title chore(manifests): added success and failure manifests Added success and failure cases to manifests May 18, 2024
@zanete zanete mentioned this pull request May 21, 2024
Closed
12 tasks
jmcook1186
jmcook1186 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated import paths for sci and sci-m as they have recently migrated to builtins. Otherwise lgtm.

@jmcook1186
Merge branch 'main' into update-manifests
d6406f0 
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
@jmcook1186 jmcook1186 merged commit d468887 into main May 22, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the update-manifests branch May 22, 2024 08:38
@jmcook1186 jmcook1186 restored the update-manifests branch May 22, 2024 08:39
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@MariamKhalatova MariamKhalatova

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariamKhalatova @narekhovhannisyan @jmcook1186