Add copy-param to builtins #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
requested review from
manushak,
MariamKhalatova and
narekhovhannisyan
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
src/builtins/copy-param/index.ts
Outdated
| * Checks for required fields in input. | ||
| */ | ||
| const validateSingleInput = (input: PluginParams, parameter: string) => { | ||
| if (!input[parameter]) { |
There was a problem hiding this comment.
please use zod validator to validate (you can check zero-tolerant plugins branch)
manushak
reviewed
Jun 25, 2024
Co-authored-by: Manushak Keramyan <manushak.keramyan@gmail.com> Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Co-authored-by: Manushak Keramyan <manushak.keramyan@gmail.com> Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
narekhovhannisyan
approved these changes
Jun 27, 2024
manushak
approved these changes
Jun 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
Adds copy-param to builtins
Closes #853