Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom files to allow build with JDK 14 #22

Closed
wants to merge 1 commit into from
Closed

Update pom files to allow build with JDK 14 #22

wants to merge 1 commit into from

Conversation

joss-enet
Copy link

JAXB is not available by default with JDK 9+, add a dependency.
Url for geotools is not valid, change it to working url.

JAXB is not available by default with JDK 9+, add a dependency.
Url for geotools is not valid, change it to working url.
@msrocka
Copy link
Member

msrocka commented Apr 29, 2021

Thank you for your pull request and sorry for not merging it. I am fine with the change of the GeoTools repository URL but adding the JAXB dependencies would also require a corresponding update in the olca-app repository. Version 1.x is only compatibel with Java 8 and freezed for urgent patches only (there are also other things that break with Java > 9 there (e.g. in GeoTools!)).

Starting from openLCA 2 olca-modules and olca-app will be compatible with Java >= 14 (see the master). We decided to go with the new Jakarta XML Binding APIs from https://eclipse-ee4j.github.io/jaxb-ri/. This is not compatible with the JAXB implementation you added. So I think, we will not merge this also for this reason.

@msrocka msrocka closed this Apr 29, 2021
@msrocka
Copy link
Member

msrocka commented Apr 29, 2021

Thank you for your pull request and sorry for not merging it. I am fine with the change of the GeoTools repository URL but adding the JAXB dependencies would also require a corresponding update in the olca-app repository. Version 1.x is only compatibel with Java 8 and freezed for urgent patches only (there are also other things that break with Java > 9 there (e.g. in GeoTools!)).

Starting from openLCA 2 olca-modules and olca-app will be compatible with Java >= 14 (see the master). We decided to go with the new Jakarta XML Binding APIs from https://eclipse-ee4j.github.io/jaxb-ri/. This is not compatible with the JAXB implementation you added. So I think, we will not merge this also for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants