Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empting, soaking, stackable item use and other misc #504

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Mar 28, 2024

No description provided.

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@GregHib GregHib marked this pull request as ready for review March 28, 2024 18:25
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 45.71429% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 31.40%. Comparing base (4f9aaca) to head (2219901).

Additional details and impacted files
Files Coverage Δ
...ld/gregs/voidps/engine/inv/transact/Transaction.kt 100.00% <100.00%> (+9.09%) ⬆️
...tlin/world/gregs/voidps/engine/timer/TimerQueue.kt 95.45% <100.00%> (+0.21%) ⬆️
...oidps/engine/inv/transact/TransactionController.kt 93.93% <88.88%> (+14.52%) ⬆️
.../main/kotlin/world/gregs/voidps/bot/TaskManager.kt 56.25% <0.00%> (ø)
...regs/voidps/world/activity/skill/cooking/Empty.kts 0.00% <0.00%> (ø)
...rld/interact/entity/combat/hit/CombatHitsplats.kts 57.14% <40.00%> (-6.69%) ⬇️
.../voidps/engine/data/config/ItemOnItemDefinition.kt 0.00% <0.00%> (ø)
...n/kotlin/world/gregs/voidps/bot/DecisionMaking.kts 17.50% <0.00%> (-1.95%) ⬇️
.../gregs/voidps/world/activity/skill/ItemOnItems.kts 53.00% <42.50%> (+5.08%) ⬆️

... and 7 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #504      +/-   ##
============================================
+ Coverage     31.36%   31.40%   +0.04%     
- Complexity     4342     4351       +9     
============================================
  Files          1223     1223              
  Lines         39109    39119      +10     
  Branches       8257     8253       -4     
============================================
+ Hits          12266    12286      +20     
+ Misses        24056    24051       -5     
+ Partials       2787     2782       -5     
Components Coverage Δ
Content 22.37% <36.53%> (+0.03%) ⬆️
Engine 41.54% <72.22%> (+0.12%) ⬆️
Network 71.14% <ø> (ø)

@GregHib GregHib changed the title Empting, stackable item on item and damage soaking Empting, soaking, stackable item on item and other misc Mar 28, 2024
@GregHib GregHib changed the title Empting, soaking, stackable item on item and other misc Empting, soaking, stackable item use and other misc Mar 28, 2024
@GregHib GregHib merged commit cb86ec0 into main Mar 28, 2024
5 checks passed
@GregHib GregHib deleted the item-on-item branch March 28, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant