Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievement task fixes #546

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Achievement task fixes #546

merged 7 commits into from
Jul 1, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jun 28, 2024

Copy link

github-actions bot commented Jun 28, 2024

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 2.85714% with 68 lines in your changes missing coverage. Please review.

Project coverage is 34.04%. Comparing base (92fcaef) to head (b9d7077).

Additional details and impacted files
Files Coverage Δ
...n/world/gregs/voidps/engine/data/AccountManager.kt 76.71% <100.00%> (+0.32%) ⬆️
...voidps/world/activity/achievement/ExplorerJack.kts 2.38% <ø> (ø)
...world/interact/entity/player/display/GameFrame.kts 79.59% <ø> (+0.74%) ⬆️
...ld/activity/achievement/LumbridgeBeginnerTasks.kts 59.40% <50.00%> (-0.26%) ⬇️
...s/voidps/world/map/varrock/abyss/MageOfZamorak.kts 39.53% <0.00%> (-0.16%) ⬇️
...ld/gregs/voidps/engine/map/collision/Collisions.kt 1.21% <0.00%> (-3.13%) ⬇️

... and 7 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #546      +/-   ##
============================================
- Coverage     34.09%   34.04%   -0.06%     
+ Complexity     4766     4764       -2     
============================================
  Files          1291     1291              
  Lines         42766    42825      +59     
  Branches       9151     9157       +6     
============================================
- Hits          14583    14579       -4     
- Misses        24923    24983      +60     
- Partials       3260     3263       +3     
Components Coverage Δ
Content 27.46% <33.33%> (-0.03%) ⬇️
Engine 43.56% <1.49%> (-0.29%) ⬇️
Network 71.29% <ø> (ø)

@GregHib GregHib merged commit d1d0adf into main Jul 1, 2024
5 checks passed
@GregHib GregHib deleted the task-fixes branch July 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random tile within area doesn't account for size
1 participant