Implement fluid covers #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pump cover now uses millibuckets in all its variables and all conversions from or to the necessary unit to be either displayed or used are done in-place.
This is the first half of the fix. The second half will be separating the change callback from item stack updating.
Separate persisting filters from onUpdate callback & automatically apply stack size config in robot arm.
|
Done. |
|
In case it helps with reviewing - this PR has 3 blocks that can be seen as one logical "unit" each:
|
Yefancy
approved these changes
Aug 12, 2023
Yefancy
pushed a commit
that referenced
this pull request
Aug 12, 2023
* refactor: extract enum selection to EnumSelectorWidget * refactor: cleanup PumpCover * fix: leveling issues on covers * refactor: rework pump cover logic The pump cover now uses millibuckets in all its variables and all conversions from or to the necessary unit to be either displayed or used are done in-place. * fix: use correct covers for ZPM and UV tiers * style: reformat multi tier covers in GTItems * fix: correctly apply stack size on item filters in robot arms (part 1) This is the first half of the fix. The second half will be separating the change callback from item stack updating. * feat: add fluid regulator cover * fix: correctly apply stack size on item filters in robot arms (part 2) Separate persisting filters from onUpdate callback & automatically apply stack size config in robot arm. * fix: errors on loading fluid filter * fix: filter ui not updating when removing filter * feat: fluid filter stack size & fluid regulator GUI * refactor: PumpCover visibility & cleanup * feat: TRANSFER_EXACT mode for fluid regulator cover * fix: correct initial transfer per second for pump cover * chore: update IFluidTransfer implementations for next LDLib version * feat: KEEP_EXACT mode for fluid regulator cover * chore: update LDLib to 1.0.17 * fix: stack/transfer size input visibility in fluid regulator & robot arm * fix: cases where supply amount > max transfer left in fluid regulator * refactor: cleanup item voiding covers * fix: UI title on item voiding cover * fix: stack size input visibility in advanced item voiding cover * feat: fluid voiding covers (UI only) * refactor: move enumerateDistinctFluids() to PumpCover * feat: implement logic for fluid voiding covers * refactor: move platform specific fluid calculation out of BucketMode
lukaslcf
pushed a commit
to lukaslcf/GregTechCEu-1.19
that referenced
this pull request
Aug 25, 2023
* refactor: extract enum selection to EnumSelectorWidget * refactor: cleanup PumpCover * fix: leveling issues on covers * refactor: rework pump cover logic The pump cover now uses millibuckets in all its variables and all conversions from or to the necessary unit to be either displayed or used are done in-place. * fix: use correct covers for ZPM and UV tiers * style: reformat multi tier covers in GTItems * fix: correctly apply stack size on item filters in robot arms (part 1) This is the first half of the fix. The second half will be separating the change callback from item stack updating. * feat: add fluid regulator cover * fix: correctly apply stack size on item filters in robot arms (part 2) Separate persisting filters from onUpdate callback & automatically apply stack size config in robot arm. * fix: errors on loading fluid filter * fix: filter ui not updating when removing filter * feat: fluid filter stack size & fluid regulator GUI * refactor: PumpCover visibility & cleanup * feat: TRANSFER_EXACT mode for fluid regulator cover * fix: correct initial transfer per second for pump cover * chore: update IFluidTransfer implementations for next LDLib version * feat: KEEP_EXACT mode for fluid regulator cover * chore: update LDLib to 1.0.17 * fix: stack/transfer size input visibility in fluid regulator & robot arm * fix: cases where supply amount > max transfer left in fluid regulator * refactor: cleanup item voiding covers * fix: UI title on item voiding cover * fix: stack size input visibility in advanced item voiding cover * feat: fluid voiding covers (UI only) * refactor: move enumerateDistinctFluids() to PumpCover * feat: implement logic for fluid voiding covers * refactor: move platform specific fluid calculation out of BucketMode
screret
added a commit
that referenced
this pull request
Nov 23, 2023
* refactor: extract enum selection to EnumSelectorWidget * refactor: cleanup PumpCover * fix: leveling issues on covers * refactor: rework pump cover logic The pump cover now uses millibuckets in all its variables and all conversions from or to the necessary unit to be either displayed or used are done in-place. * fix: use correct covers for ZPM and UV tiers * style: reformat multi tier covers in GTItems * fix: correctly apply stack size on item filters in robot arms (part 1) This is the first half of the fix. The second half will be separating the change callback from item stack updating. * feat: add fluid regulator cover * fix: correctly apply stack size on item filters in robot arms (part 2) Separate persisting filters from onUpdate callback & automatically apply stack size config in robot arm. * fix: errors on loading fluid filter * fix: filter ui not updating when removing filter * feat: fluid filter stack size & fluid regulator GUI * refactor: PumpCover visibility & cleanup * feat: TRANSFER_EXACT mode for fluid regulator cover * fix: correct initial transfer per second for pump cover * chore: update IFluidTransfer implementations for next LDLib version * feat: KEEP_EXACT mode for fluid regulator cover * chore: update LDLib to 1.0.17 * fix: stack/transfer size input visibility in fluid regulator & robot arm * fix: cases where supply amount > max transfer left in fluid regulator * refactor: cleanup item voiding covers * fix: UI title on item voiding cover * fix: stack size input visibility in advanced item voiding cover * feat: fluid voiding covers (UI only) * refactor: move enumerateDistinctFluids() to PumpCover * feat: implement logic for fluid voiding covers * refactor: move platform specific fluid calculation out of BucketMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PumpCover