Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cable effects #567

Merged
merged 17 commits into from
Mar 21, 2022
Merged

Cable effects #567

merged 17 commits into from
Mar 21, 2022

Conversation

brachy84
Copy link
Contributor

@brachy84 brachy84 commented Jan 23, 2022

Add a heat effect when a cable overvolts or overamps. When it get's heat a particle is spawned and a ticker is scheduled. It wills top ticking if the cable burned or it cooled down to normal temperature.

When cable overvolts, the transfered amount is limited to max cable voltage and rest is yeeted.
When cable overamps, the cable currently transfers normally.

Also adds a sink mode to creative energy source

2022-01-23_11 36 06

The default temperature is 293 K (room temperature)
From 500 K - 1000 K it will raise the color alpha value from 0 to 0.8
At 1000 it will start changing the color according to these values. To make it look smooth the colors are interpolated.
(added colors for up to 20000 K)
grafik

The temperature the cable melts is 3000 K currently.
Cables with insulation will loose the insulation add a random point starting at 1500K.

@Zalgo239
Copy link
Member

That looks very nice, I also like limiting the transfer to the cable max and voiding the rest the most

@Rongmario
Copy link
Contributor

Looks great so far apart from some leftover visible logging. I also agree with the first proposal.

@Yefancy
Copy link
Contributor

Yefancy commented Jan 23, 2022

really impressive

@Zalgo239
Copy link
Member

What if the glowing cable lit up the surroundig area to make the effect more convincing? Definitely not going to use that to turn my power lines into incandescent light bulbs

@Yefancy
Copy link
Contributor

Yefancy commented Mar 8, 2022

There are basically fine to me, didn't find serious problems aboutthe particles lifecycle. my comments are not a fatal or necessary changes.

btw, awesome effect

@TechLord22 TechLord22 merged commit b096789 into master Mar 21, 2022
@TechLord22 TechLord22 deleted the cable-effects branch March 21, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants