-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cable effects #567
Cable effects #567
Conversation
That looks very nice, I also like limiting the transfer to the cable max and voiding the rest the most |
Looks great so far apart from some leftover visible logging. I also agree with the first proposal. |
really impressive |
What if the glowing cable lit up the surroundig area to make the effect more convincing? |
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityCreativeEnergy.java
Show resolved
Hide resolved
src/main/java/gregtech/common/pipelike/cable/tile/TileEntityCable.java
Outdated
Show resolved
Hide resolved
There are basically fine to me, didn't find serious problems aboutthe particles lifecycle. my comments are not a fatal or necessary changes. btw, awesome effect |
Add a heat effect when a cable overvolts or overamps. When it get's heat a particle is spawned and a ticker is scheduled. It wills top ticking if the cable burned or it cooled down to normal temperature.
When cable overvolts, the transfered amount is limited to max cable voltage and rest is yeeted.
When cable overamps, the cable currently transfers normally.
Also adds a sink mode to creative energy source
The default temperature is 293 K (room temperature)
From 500 K - 1000 K it will raise the color alpha value from 0 to 0.8
At 1000 it will start changing the color according to these values. To make it look smooth the colors are interpolated.
(added colors for up to 20000 K)
The temperature the cable melts is 3000 K currently.
Cables with insulation will loose the insulation add a random point starting at 1500K.