-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image orientation squeezes in shiny display #54
Comments
Thanks for reporting this! I have to say that our images where always more or less quadratic, so I never noticed that.
Totally agree, I will look into it. Probably this can be made responsive to screen size. |
I made some changes to address this:
It would be great if you could give this a try and let me know if it looks better now. The changes are on the
|
i will try this on Friday |
I actually have time today but I was hoping to just run the new shiny app, if possible. I tried |
I copied the contents from dev branch app.R to my output directory and reran the docker. I don't see a difference in the carousel The rosette explorer looks perfect rosette experimentThis was confusing because at first I got a new error: I noticed on line 29 of app.R you are reading in a fixed filename so I realized you are reading the original datafile and attempting to join the metadata. I actually only need to provide the metadata and not the traits themselves. I would suggest adding a note in the popup that no columns from the traits file should be in the metadata file except the one exception is that it doesn't recognize the factors as factors and instead orders them alphanumerically. I realize this is a constraint of saving to csv so i'm not sure how you'd improve that functionality. |
also, the yellow is pretty hard to see. I've found a background color of 'grey40' to work pretty well as a compromise for both dark and light colors. |
The number of images should now scale according to screen size. I can't do much about the whitespace between the images, that is how slickR renders the carousel thing and I can't seem to find an option to control this.
I changed the plot to be 600x600 and also increased the image size in the rosette explorer to be consistent
Good point, I added something like that. I guess it was not clear enough that the metadata is joined with the pipeline output.
True, I changed the color map slightly and increased the line thickness Thanks for your suggestions! |
It looks like the rosette carousel is expecting landscape images. when using portrait images it creates white space which makes everything smaller than it needs to be and hard to see.
it would be nice to also have a choice how many images to view next to each other. on my labtop 3 I'd say I have room for 3 but on my external monitor i could probably comfortably view 6 or more.
in the rosette explorer it squeezes the images unnaturally
The text was updated successfully, but these errors were encountered: