Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Imagick implementation #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

soullivaneuh
Copy link
Collaborator

Refer to #34, I started a PR for Imagick implementation.

@hast and @nick4fake, please tell me if you already start to work on it!

Here my TODO list:

  • Fill Imagick adapter class
  • If needed, adapt common adapter classes and GD
  • Write test for Imagick adapter class
  • Adapt test if common and/or GD classes are modified
  • Update documentation
  • Write an implementation on ImageBundle
  • Update composer.json. ext-gd should NOT be required but suggested

Please tell me if you think I missed some points on TODO list.

Some questions for @Gregwar:

  • How do you use demo files?
  • How do you manage your test? How can I implement proper test for Imagick?
  • Imagick generaly throw errors when a function failed like cropImage for example. How should I manage it in adapter?
    I will work on it some evenings and weekends, hope to finish that quickly.

Thanks.

@ozahorulia
Copy link
Contributor

@soullivaneuh you can see what I've done here: https://github.com/Hast/Image/commit/38cb28a1b8ab645ba1ff0bfa3feb4382bc848efc
Unfortunately, have no enough time to continue right now.

@soullivaneuh
Copy link
Collaborator Author

Ok thanks, will take a look.

@soullivaneuh
Copy link
Collaborator Author

@Gregwar Integrate Imagick adapter is a little bit complicated as the functions and parameters are often differents.

Imagine already do that: http://imagine.readthedocs.org/en/latest/

I'm not sure if it's a good idea to integrate it on Image or ImageBundle directly, but this, integrated on symfony, could be very simplier.

What is your think?

Thanks.

@Gregwar
Copy link
Owner

Gregwar commented Dec 3, 2014

Hi @soullivaneuh
Thanks for opening this

The demo files are only here to test quickly some case by hand, and to show some examples. I personally run them manually.

Tests are based on phpunit, It could be adapted to be run for both GD and Imagick if you want.

What kind of failure are you mentioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants