-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce the region lease keeper #2645
Merged
MichaelScofield
merged 8 commits into
GreptimeTeam:develop
from
WenyXu:feat/region-lease-keeper
Nov 2, 2023
Merged
feat: introduce the region lease keeper #2645
MichaelScofield
merged 8 commits into
GreptimeTeam:develop
from
WenyXu:feat/region-lease-keeper
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
3 times, most recently
from
October 24, 2023 05:16
f300245
to
f3dbbad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2645 +/- ##
===========================================
- Coverage 85.10% 84.73% -0.38%
===========================================
Files 754 758 +4
Lines 120911 121219 +308
===========================================
- Hits 102902 102710 -192
- Misses 18009 18509 +500 |
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
2 times, most recently
from
October 24, 2023 06:18
45ddd84
to
4e1778e
Compare
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
2 times, most recently
from
October 24, 2023 15:28
bce0879
to
6eb8658
Compare
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
from
October 31, 2023 06:04
8ac346e
to
9f18d1c
Compare
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
from
October 31, 2023 07:19
9f18d1c
to
e1c0c5c
Compare
fengjiachun
reviewed
Oct 31, 2023
fengjiachun
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
from
November 2, 2023 04:23
e623034
to
3b4e820
Compare
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
from
November 2, 2023 04:30
3b4e820
to
8fe8f9c
Compare
WenyXu
force-pushed
the
feat/region-lease-keeper
branch
from
November 2, 2023 04:43
8fe8f9c
to
32ec24d
Compare
@MichaelScofield PTAL |
MichaelScofield
approved these changes
Nov 2, 2023
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Introduces the new region lease keeper, which utilizes the
LeaderCachedKvStore
.The
find_staled_leader_regions
method, returns staled Leader regions:datanode_id
isn't the corresponding leader peer inregion_routes
.Checklist
Refer to a related PR or issue link (optional)
#2636