Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for region migration procedure #2895

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 8, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add flow test for open candidate region with retryable error
  2. Add flow test for upgrade candidate retry failed
  3. Add flow test for upgrade candidate with retry

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu mentioned this pull request Dec 8, 2023
39 tasks
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #2895 (7a70202) into develop (5a99f09) will decrease coverage by 0.54%.
The diff coverage is 98.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2895      +/-   ##
===========================================
- Coverage    85.06%   84.53%   -0.54%     
===========================================
  Files          753      753              
  Lines       119059   119400     +341     
===========================================
- Hits        101281   100938     -343     
- Misses       17778    18462     +684     

@WenyXu WenyXu self-assigned this Dec 11, 2023
@WenyXu
Copy link
Member Author

WenyXu commented Dec 12, 2023

@fengjiachun PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Dec 13, 2023
Merged via the queue into GreptimeTeam:develop with commit 3c24ca1 Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants